Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7550ac5) 89.90% compared to head (e496ff0) 74.47%.

@@             Coverage Diff             @@
##           master     #253       +/-   ##
===========================================
- Coverage   89.90%   74.47%   -15.43%     
===========================================
  Files          25       25               
  Lines        3208     3205        -3     
===========================================
- Hits         2884     2387      -497     
- Misses        324      818      +494     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi, thanks for the PR.
I think these type piracies are fine.
In addition, I suggest beautiful_generating_set instead of beautifully_generators/beautifuly_generators.
@pogudingleb

I don't think so. Why wouldn't those two methods get upstreamed? They seem like generally useful functions for the package that defines the algebraic types?

@ArnoStrouwen Thanks!

In addition, I suggest beautiful_generating_set instead of beautifully_generators/beautifuly_generators.
@pogudingleb

I also like this better. Another option would be to simplify_generators

Why wouldn't those two methods get upstreamed?
They seem like generally useful functions for the package that defines the algebraic types?

I agree with Chris, at least for vars, I have created an issue for this.

Right, I agree, we can rename total_degree, and vars can perhaps be defined in AbstractAlgebra.jl. I will open an issue there once I land

Right, I agree, we can rename total_degree, and vars can perhaps be defined in AbstractAlgebra.jl. I will open an issue there once I land

I guess, they would rather appreciate a PR)

Superseded by #274